Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloom filter part IV: adjust writer properties, bloom filter properties, and incorporate into column encoder #3165

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Nov 23, 2022

Which issue does this PR close?

Rationale for this change

mostly documented in #3138

What changes are included in this PR?

  1. update number of properties
  2. push down hashing to encoder level
  3. add more docs

Are there any user-facing changes?

Screenshot 2022-11-23 at 15 25 31

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 23, 2022
1. update number of properties
2. push down hashing to encoder level
3. add more docs
@jimexist jimexist requested review from alamb and tustvold and removed request for alamb November 23, 2022 07:59
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I may do a second pass prior to the release tomorrow, but this looks good to me. Thank you for all your work on this 👍

@tustvold tustvold merged commit 5640a5b into apache:master Nov 24, 2022
@ursabot
Copy link

ursabot commented Nov 24, 2022

Benchmark runs are scheduled for baseline = 8ba7842 and contender = 5640a5b. 5640a5b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Nov 27, 2022

Thank you for all your work on this feature @jimexist -- it is really cool to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit and create a document for bloom filter configurations
4 participants